fix: Video Editor Accent Color #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the accent color used in the Video Editor component by replacing a SCSS variable reference with a hardcoded hex color value.
- Replaces the SCSS variable
variables.$godam-primary-text-colorwith the hardcoded color#ab3a6cfor the--wp-components-color-accentCSS custom property
| #root-easydam, | ||
| #root-video-editor { | ||
| --wp-components-color-accent: variables.$godam-primary-text-color; | ||
| --wp-components-color-accent: #ab3a6c; |
There was a problem hiding this comment.
Using a hardcoded color value instead of the existing SCSS variable reduces maintainability. Consider defining this color as a SCSS variable (e.g., $video-editor-accent-color: #ab3a6c;) to maintain consistency with the existing color system and make future color changes easier.
subodhr258
requested review from
KMchaudhary,
kishan-gondaliya-7270 and
prachigarg19
kishan-gondaliya-7270
approved these changes
Aug 11, 2025
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small visual update to the admin interface by changing the accent color used for WordPress components in the
#root-easydamand#root-video-editorsections. The accent color is now set to#ab3a6cinstead of using the$godam-primary-text-colorvariable.