Fix Video SEO Data Logic Edge Cases and Performance Issues#980
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses video SEO data logic edge cases and performance issues in the Godam player block. It focuses on fixing issues where existing video SEO data wasn't displaying properly and multiple API calls were being made during video replacement operations.
- Fixed backward compatibility for blocks created before the SEO feature was implemented
- Optimized video replacement workflow by batching API calls and attribute updates
- Improved state management to prevent unwanted side effects during video selection
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| assets/src/blocks/godam-player/utils/index.js | Added isSEODataEmpty utility function to properly detect empty SEO data objects |
| assets/src/blocks/godam-player/edit.js | Implemented backward compatibility logic, optimized video selection with batched updates, and added state management to prevent interference |
| assets/src/blocks/godam-player/components/VideoSEOModal.js | Updated modal to use new utility function and improved data initialization logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…deo-seo-optimization
KMchaudhary
approved these changes
Sep 29, 2025
subodhr258
approved these changes
Sep 29, 2025
Shekhar0109
pushed a commit
to Shekhar0109/godam
that referenced
this pull request
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Overview
ISSUE: #975
🐞 Bug Fixes
🚀 Enhancements
📝 Notes