fix: suppress fatal errors in Algolia_Index::get_indexable_records_from_post#43
Merged
justlevine merged 16 commits intomainfrom Nov 9, 2025
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
justlevine
changed the title
Algolia_Index::get_indexable_records_from_postAlgolia_Index::get_indexable_records_from_post
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling and documentation in the Algolia indexing process. The main changes wrap the record creation logic in a try-catch block to prevent a single failing post from breaking the entire indexing batch, and improves PHPDoc type hints for better code clarity.
Key changes:
- Added try-catch error handling around post-to-record conversion logic to gracefully skip problematic posts
- Updated PHPDoc type hints to use standardized
array<string,mixed>notation for better IDE support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
up1512001
previously approved these changes
Nov 7, 2025
up1512001
approved these changes
Nov 7, 2025
justlevine
deleted the
fix/suppress-fatals-get_indexable_records_from_post
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR wraps the Post parsing and chunking in
Algolia_Index::get_indexable_records_from_post()inside a try-catch block, to silently prevent any fatal errors that would otherwise stop indexing entirely.Important
This PR is based on #38 which should be merged first.
Technical Details
Checklist
Screenshots
To-do
Fixes/Covers issue
Fixes #22