Skip to content

Fix: QA issues#91

Merged
up1512001 merged 3 commits intodevelopfrom
fix/qa-issues
Dec 19, 2025
Merged

Fix: QA issues#91
up1512001 merged 3 commits intodevelopfrom
fix/qa-issues

Conversation

@up1512001
Copy link
Copy Markdown
Member

Technical Details

Address Fatal error plus fix QA issues.

05:36:09 AM	
PHP message: Fatal error: Uncaught Error: Class "GFAPI" not found in /var/www/wp-content/plugins/rt-blocks/inc/classes/blocks/class-form-modal-handler.php:163

05:36:09 AM	
Stack trace:

05:36:09 AM	
#0 /var/www/wp-content/plugins/rt-blocks/inc/classes/blocks/class-form-modal-handler.php(111): Rt_Blocks\Features\Inc\Blocks\Form_Modal_Handler->get_display_title('203')
{"code":"qm_fatal","message":"Uncaught Error: Undefined constant \"OneSearch\\ONESEARCH_DIR\" in ~/app/public/wp-content/plugins/onesearch/inc/Autoloader.php

Checklist

Screenshots

To-do

Fixes/Covers issue

Fixes #

Part of https://github.com/rtCamp/OnePress/issues/59#issuecomment-3674061736

@up1512001 up1512001 self-assigned this Dec 19, 2025
Comment thread uninstall.php
@up1512001 up1512001 requested a review from justlevine December 19, 2025 11:22
Comment thread assets/src/components/SiteIndexableEntities.js
Comment thread inc/Modules/Search/Post_Record.php
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses QA issues and fixes fatal errors in the OneSearch plugin. The main focus is preventing fatal errors related to undefined constants during plugin uninstall and handling exceptions during content processing, along with UI improvements to the settings interface.

  • Adds fallback constant definition for ONESEARCH_DIR in uninstall.php to prevent fatal errors
  • Wraps the_content filter application in try-catch block to handle exceptions gracefully
  • Implements state management to disable UI controls during save operations and adds a confirmation modal for re-indexing

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
uninstall.php Adds conditional definition of ONESEARCH_DIR constant to prevent fatal error when plugin files are deleted during uninstall
inc/Modules/Search/Post_Record.php Wraps the_content filter in try-catch to handle exceptions during content processing
assets/src/components/SiteSearchSettings.js Adds isIndexableEntitiesSaving prop and disables controls during entity saving operations
assets/src/components/SiteIndexableEntities.js Lifts saving state to parent component, adds confirmation modal for re-indexing with explanatory text
assets/src/admin/search/index.js Introduces shared saving state and passes it to child components for coordinated UI control

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread assets/src/components/SiteIndexableEntities.js Outdated
Comment thread inc/Modules/Search/Post_Record.php
Comment thread assets/src/components/SiteIndexableEntities.js
Comment thread assets/src/components/SiteIndexableEntities.js
Copy link
Copy Markdown
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be squash-merged when the remaining comments are resolved. No need to ping for rereview 🚀

@up1512001 up1512001 merged commit cebefb6 into develop Dec 19, 2025
6 of 7 checks passed
@up1512001 up1512001 deleted the fix/qa-issues branch December 19, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants