Skip to content

Conversation

@krishana7911
Copy link
Contributor

Summary

This PR forces BuddyPress to use the Legacy template pack instead of Nouveau, but only when both Godam theme and rtMedia are active.

Motivation

  • Problem:
    When using BuddyPress Nouveau with Godam theme + rtMedia, the Nouveau CSS introduces conflicts with rtMedia video players inside activity feeds. This results in broken video controls and styling inconsistencies.

  • Solution:
    Switching to Legacy templates provides:

    • Fewer CSS conflicts
    • More predictable markup
    • Better compatibility with third-party plugins like rtMedia
    • Cleaner integration with Godam’s custom styling

Justification

  • Nouveau is more modern, but it injects opinionated CSS and structures that don’t align well with Godam’s design + rtMedia video handling.
  • Legacy templates are simpler and proven to be more stable in this environment.
  • This change only applies when Godam theme and rtMedia are active together, so it will not impact other themes or setups.

Impact

  • Improved video playback experience with rtMedia inside activity feeds.
  • Prevents layout breaking and missing video controls caused by Nouveau styles.
  • No effect on users who are not running Godam + rtMedia.

@krishana7911 krishana7911 requested a review from Copilot September 2, 2025 05:15
@krishana7911 krishana7911 self-assigned this Sep 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses compatibility issues between BuddyPress Nouveau templates and rtMedia video players when used with the Godam theme by forcing the use of Legacy templates to prevent CSS conflicts and broken video controls.

  • Forces BuddyPress to use Legacy template pack instead of Nouveau when specific conditions are met
  • Updates settings retrieval from multisite-safe get_site_option() to single-site get_option()
  • Adds template override functionality to resolve video player styling conflicts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@krishana7911 krishana7911 merged commit bfce9ee into develop Sep 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants