Skip to content

Fix: Add authorization checks for media deletion #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishana7911 merged 4 commits into from
Apr 6, 2026
+42 −2
Merged

Fix: Add authorization checks for media deletion #2321

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b5cb92
Merge pull request #2286 from rtCamp/develop
nazmulthenomad Jan 30, 2026
d40b50d
Merge pull request #2297 from rtCamp/update/packages
nazmulthenomad Feb 23, 2026
1262193
Fix: add authorization checks for media deletion
krishana7911 Apr 6, 2026
93bf771
Update: removed comment
krishana7911 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions app/main/controllers/template/rtmedia-ajax-actions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

/**
* Delete uploaded media.
* Modified 10-02-2019 by Adarsh Verma <adarsh.verma@rtcamp.com>
* Patched to include Ownership and Authorization checks.
*/
function rtmedia_delete_uploaded_media() {

Expand All @@ -17,6 +17,47 @@ function rtmedia_delete_uploaded_media() {

if ( ! empty( $action ) && 'delete_uploaded_media' === $action && ! empty( $media_id ) ) {
if ( wp_verify_nonce( $nonce, 'rtmedia_' . get_current_user_id() ) ) {

$model = new RTMediaModel();
$media = $model->get( array( 'id' => $media_id ) );

// Check if media exists
if ( empty( $media ) || ! isset( $media[0] ) ) {
wp_send_json_error(
array(
'code' => 'rtmedia-media-not-found',
'message' => esc_html__( 'Media not found.', 'buddypress-media' ),
Comment thread
krishana7911 marked this conversation as resolved.
)
);
wp_die();
}

$current_user_id = get_current_user_id();
$media_author = (int) $media[0]->media_author;

// 1. Is the user the owner of the media?
$is_owner = ( $current_user_id === $media_author );

// 2. Is the user a site administrator?
$is_admin = current_user_can( 'manage_options' ) || current_user_can( 'delete_others_posts' );

// 3. Is the user a BuddyPress Group Admin? (if the media belongs to a BP group)
$is_group_admin = false;
if ( ! empty( $media[0]->context ) && 'group' === $media[0]->context && function_exists( 'groups_is_user_admin' ) ) {
$is_group_admin = groups_is_user_admin( $current_user_id, $media[0]->context_id );
}

// If none of the above are true, block the deletion
if ( ! $is_owner && ! $is_admin && ! $is_group_admin ) {
wp_send_json_error(
array(
'code' => 'rtmedia-unauthorized',
'message' => esc_html__( 'You do not have permission to delete this media.', 'buddypress-media' ),
)
);
wp_die();
}

$remaining_album = 0;
$remaining_photos = 0;
$remaining_music = 0;
Expand All @@ -29,7 +70,6 @@ function rtmedia_delete_uploaded_media() {
if ( class_exists( 'RTMediaNav' ) ) {
global $bp;
$rtmedia_nav_obj = new RTMediaNav();
$model = new RTMediaModel();
$other_count = 0;

if ( function_exists( 'bp_is_group' ) && bp_is_group() ) {
Expand Down
Loading