Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@Utsav-Ladani
Copy link
Contributor

Fix PHP deprecation errors for PHP@8.1

Fixes done in this PR

  • File: custom-functions.php
    • Change the null default value to 0 as the type is array|int.
  • File: rt-transcoder-handler.php
    • Change the apikey to string before passing to the trim() function because it gives an error if a parameter is not of type string.
    • Remove default arguments from the send_notification method because there should be no required arguments after default arguments in the method/function. Also added validation to convert it into an Array.
  • Also few other changes have been made to fix the phpcs errors.

Related Issues

Fix deprecation errors and phpcs errors

Closes: 275
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Utsav-Ladani Utsav-Ladani merged commit 686feee into develop Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants