Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Fix js script dependency error #278

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix js script dependency error #278

merged 1 commit into from
Oct 19, 2023

Conversation

@Utsav-Ladani
Copy link
Contributor

@Utsav-Ladani Utsav-Ladani commented Oct 19, 2023

Fix js script dependency error

Changes

  • Add a check to enqueue a script only when the rtMedia plugin is activated.
  • class_exists( 'RTMedia' ) is used to check this.
  • This script is making changes to rtMedia UI components. So it is not required when rtMedia is deactivated/not installed.

@Utsav-Ladani
fix(app): Add condition to enqueue script from transcoder
a6d3576 
Enqueue script only if rtMedia class is exists. This script add some UI changes to rtMedia component, when it is used with transcoder.
vishalkakadiya
vishalkakadiya approved these changes Oct 19, 2023
View reviewed changes
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Utsav-Ladani Utsav-Ladani merged commit 5663304 into develop Oct 19, 2023
@Utsav-Ladani Utsav-Ladani deleted the fix/rtMedia-js-dependency branch October 19, 2023 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vishalkakadiya vishalkakadiya vishalkakadiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Utsav-Ladani @vishalkakadiya