Update Node Packages #305
Update Node Packages #305
Conversation
| "scripts": { | ||
| "build": "cross-env BABEL_ENV=default NODE_ENV=production webpack --mode production --progress", | ||
| "dev-test": "cross-env BABEL_ENV=default NODE_ENV=development webpack", | ||
| "dev": "cross-env BABEL_ENV=default webpack --watch --mode development --progress" |
There was a problem hiding this comment.
Running this changeset gives us a dependency error because of grunt.
Also, why have we not pushed the package-lock.json file?
Detailed log:
2025-02-27T08_01_29_206Z-debug-0.log
Steps to reproduce:
- Clone a new repo.
- Checkout
build/update-packagesbranch. - Run:
nvm use && npm install.
There was a problem hiding this comment.
@Pathan-Amaankhan The error is because of grunt-autoprefixer which is deprecated by grunt-postcss which is also archived, and there is no replacement package for that. After reading the current commands, I have not found use case where we are currently using grunt pipeline so I have preserved them if they are used elsewhere in CI/CD.
There was a problem hiding this comment.
@Vedant-Gandhi,
We are using grunt-autoprefixer in Gruntfile.js.
A better alternative for grunt-autoprefixer can be autoprefixer.
There was a problem hiding this comment.
Can we also update the depricated packages.
There was a problem hiding this comment.
@Pathan-Amaankhan I have updated the deprecated package to use @wordpress/eslint-plugin, but it has its own dependencies as eslint 8.57.1, which conflicts with our current 9.21.0. The package is working properly with no issues, so we can ignore them for now.
Changes made
This PR addresses the following changes:
Ref - #302