PPPoE PADI sent to non-broadcast address

[jcpvdm]

Describe the bug

If PPPoE Discovery stage is interrupted - for example, if connection is drops after PADO is seen, session will reset discovery stage to PADI, however the destination mac-address will be not be broadcast. Instead, it will be the one learned from last PADO.

To Reproduce

Version (bngblaster -v):

Version: 0.9.31
Compiler: GNU (12.2.1)
IO Modes: packet_mmap_raw (default), packet_mmap, raw

JSON configuration:

{
    "interfaces": {
        "qdisc-bypass": false,
        "access": [
            {
                "interface": "eth1",
                "type": "pppoe",
                "vlan-mode": "1:1",
                "outer-vlan-min": 10,
                "outer-vlan-max": 10

            }
        ]
    },
    "sessions": {
        "count": 1,
        "reconnect": true,
        "start-rate": 3,
        "stop-rate": 3
    },
    "pppoe": {
        "session-time": 0,
        "reconnect": true,
        "discovery-retry": 3
    },
    "ppp": {
        "lcp": {
            "keepalive-interval": 1
        },
        "ip6cp": {
            "enable": true
        },
        "ipcp": {
            "enable": true
        }
    }

}

Steps to reproduce the behavior:

1. Init PPPoE session
2. After PADO, interrupt connection.
3. Wait for session to give up and reset to send PADI... observe dst mac-address is non-broadcast.

Expected behavior
PADI always sent with destination address = broadcast

Screenshots

22:53:56.422221 02:00:00:00:00:01 > ff:ff:ff:ff:ff:ff, ethertype 802.1Q (0x8100), length 60: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADI [Service-Name] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:53:56.436065 aa:c1:ab:26:6d:fa > 02:00:00:00:00:01, ethertype 802.1Q (0x8100), length 60: vlan 10, p 7, ethertype PPPoE D (0x8863), PPPoE PADO [Service-Name] [AC-Name "g1-pe4"] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8]
22:53:58.436247 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:03.436539 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:08.436717 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:11.496989 1a:36:00:ff:00:01 > 01:80:c2:00:00:0e, ethertype LLDP (0x88cc), length 183: LLDP, length 169: g1-agg1
22:54:13.436757 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:18.436960 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:23.437269 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:28.437769 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:33.437963 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:38.438405 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:41.498736 1a:36:00:ff:00:01 > 01:80:c2:00:00:0e, ethertype LLDP (0x88cc), length 183: LLDP, length 169: g1-agg1
22:54:43.438680 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:48.438895 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 80: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADR [Service-Name] [AC-Cookie 0x6712193A77FDD71EFF9851213C2058D8] [Vendor-Specific "......agg1-e1/1:10..session1"]
22:54:53.439053 02:00:00:00:00:01 > aa:c1:ab:26:6d:fa, ethertype 802.1Q (0x8100), length 60: vlan 10, p 0, ethertype PPPoE D (0x8863), PPPoE PADI [Service-Name] [Vendor-Specific "......agg1-e1/1:10..session1"]

[GIC-de]

This issues should be fixed in latest dev branch. Please verify.

[GIC-de]

Fixed in latest version 0.9.34!

[jcpvdm]

Verified! thank you