Skip to content

Addressing Ben's comment#15

Merged
ekr merged 2 commits intomasterfrom
ad_ben
Jun 13, 2019
Merged

Addressing Ben's comment#15
ekr merged 2 commits intomasterfrom
ad_ben

Conversation

@seanturner
Copy link
Contributor

No description provided.

Copy link

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, this is fine.

<t>
Verifying receiver consent requires some sort of explicit handshake, but conveniently
we already need one in order to do NAT hole-punching. ICE <xref target="RFC8445"/> includes a handshake
we already need one in order to do NAT hole-punching. ICE (Interactive Connectivity Establishment) <xref target="RFC8445"/> includes a handshake

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more common, I think.

Suggested change
we already need one in order to do NAT hole-punching. ICE (Interactive Connectivity Establishment) <xref target="RFC8445"/> includes a handshake
we already need one in order to do NAT hole-punching. Interactive Connectivity Establishment (ICE) <xref target="RFC8445"/> includes a handshake

@seanturner
Copy link
Contributor Author

@ekr @adamroach PTAL

@ekr ekr merged commit 4e1661c into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants