Junit replace invalid characters

[zwilias]

Fixes #615

[lydell]

Would be nice with a test case from #615 (making sure that the new test output of elm-program-test works).

[zwilias]

Would be nice with a test case from #615

Yeah, I'm a little hesitant about having node-test-runner's test-suite depend on some version of elm-program-test. Given the core-issue is that it outputs control characters, and we can test that control characters are handled, I don't feel like there's a particular need for adding an external dependency to the test suite.

That said, I can confirm it resolves the issue and results in actual XML output 😄

[lydell]

Oh, I thought it was the “▼” character that caused the problem … so elm-program-test uses \u{0008}? If it does, then the tests are all good. I didn’t mean that we should depend on elm-program-test.

Now I’m curious, why does it use control characters? (Just out of curiosity, not trying to question the need for this PR.)

[zwilias]

It uses a bunch of control characters for formatting text in the output (bold, red, green, dim, etc). This mostly means \u{001B}, though we'd want the test-runner to work with any character that's somewhat legal to have in a string 😄

I ended up with \u{0008} basically because that's the first control character that came to mind while writing a failing test for the generalised "elm-test --report junit crashes if output contains control characters" case (I don't know too many of them by heart, I have to admit.)

[lydell]

I think \u{001B} would make for a much better test case. I immediately think of terminal escapes when I see it.

[zwilias]

Cool, I went ahead and added an extra test-case. I like having both, so as to not overfit to how it happened to be elm-program-test that surfaced the issue, while also having the clarity of something a little easier to image appearing in test output!

[lydell]

Looks good to me!

@harrysarson do you have anything to say?

[zwilias]

I'm going to go ahead and merge this, we can always make fixups later.

[lydell]

Released in 0.19.1-revision12.