Skip to content

use more callbacks #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtfpessoa merged 1 commit into from
Oct 21, 2015
Merged

use more callbacks #8

rtfpessoa merged 1 commit into from
Oct 21, 2015

Conversation

@rtfpessoa
Copy link
Owner

@rtfpessoa rtfpessoa commented Oct 20, 2015

  • use callbacks on input retreival
  • minor refactor of the code
  • use process.stdin for reading stdin instead of '/dev/stdin'

@rtfpessoa
use more callbacks
f88cd6d 
* use callbacks on input retreival
* minor refactor of the code
* use process.stdin for reading stdin instead of '/dev/stdin'
@rtfpessoa
Copy link
Owner Author

rtfpessoa commented Oct 20, 2015

@pbu88 just did some refactor, including read from process.stdin.

What do you think?

@pbu88
Copy link
Contributor

pbu88 commented Oct 21, 2015

Hey @rtfpessoa, looks great! +1

rtfpessoa pushed a commit that referenced this pull request Oct 21, 2015
Merge pull request #8 from rtfpessoa/more-callbacks
307cf0c 
use more callbacks
@rtfpessoa rtfpessoa merged commit 307cf0c into master Oct 21, 2015
@rtfpessoa rtfpessoa deleted the more-callbacks branch October 21, 2015 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtfpessoa @pbu88