Check if hljs is not null only once#458
Merged
rtfpessoa merged 1 commit intortfpessoa:masterfrom Nov 4, 2022
ericcornelissen:check-hljs-once
Merged
Check if hljs is not null only once#458rtfpessoa merged 1 commit intortfpessoa:masterfrom ericcornelissen:check-hljs-once
rtfpessoa merged 1 commit intortfpessoa:masterfrom
ericcornelissen:check-hljs-once
Conversation
Update the `highlightCode` method of `Diff2HtmlUI` to check if the hljs reference is null only once (at the start). This address the "HACK" comments by using a locally scoped variable for hljs. This way, TypeScript is able to deduce that, after the initial null-check, hljs is in fact not null.
rtfpessoa
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on my previous contribution I noticed some
// HACK:comments in the code. I thought I knew a solution so I figured I could contribute it - hope it helps 🙂Let me know if you'd like to see anything changed.