Skip to content

fix(rewrite): route pnpm lint through rtk pnpm#678

Open
TechWizard9999 wants to merge 2 commits intortk-ai:developfrom
TechWizard9999:fix/rewrite-pnpm-lint-to-rtk-pnpm-lint
Open

fix(rewrite): route pnpm lint through rtk pnpm#678
TechWizard9999 wants to merge 2 commits intortk-ai:developfrom
TechWizard9999:fix/rewrite-pnpm-lint-to-rtk-pnpm-lint

Conversation

@TechWizard9999
Copy link
Copy Markdown
Contributor

Description

Fixes rewrite routing for pnpm lint so it no longer gets forced into rtk lint (which can cause ESLint-oriented retry loops in non-ESLint projects).

Related Issue

Closes #665

Changes Made

  • updated discovery pattern matching so pnpm lint is recognized by the pnpm rule path
  • removed pnpm lint from rtk lint rewrite prefixes
  • added rewrite regression tests:
    • pnpm lint -> rtk pnpm lint
    • pnpm lint --fix -> rtk pnpm lint --fix
  • added changelog note under Unreleased bug fixes

Files Changed

Testing

  • cargo fmt --all --check
  • rtk cargo clippy --all-targets (2 pre-existing warnings in untouched files)
  • rtk cargo test
  • rtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_routes_to_pnpm
  • rtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_with_args_routes_to_pnpm
  • ./target/debug/rtk rewrite "pnpm lint" -> rtk pnpm lint

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated
  • No breaking changes introduced

cc @pszymkowiak for review

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 20, 2026

CLA assistant check
All committers have signed the CLA.

@TechWizard9999
Copy link
Copy Markdown
Contributor Author

@pszymkowiak could you please review this and let me know if anything needs to change?

@JoeIaquinto
Copy link
Copy Markdown

Any movement on this?

@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Thanks for checking in, Joe.

This PR is ready from my side: the branch was cleaned and scoped to only the intended fix, and CLA recheck was also triggered.

@pszymkowiak could you please re-review when you have a moment?

@aeppling
Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

@TechWizard9999 TechWizard9999 force-pushed the fix/rewrite-pnpm-lint-to-rtk-pnpm-lint branch from 1b17d79 to 508bfda Compare March 27, 2026 01:48
@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Rebased on latest develop per the refactor notice and force-updated this branch.

@pszymkowiak could you please re-review when convenient?

@FlorianBruniaux
Copy link
Copy Markdown
Collaborator

The routing fix is correct and the regex change is sound. Two things blocking merge right now:

  1. CHANGELOG.md conflict — recent merges on develop created a conflict. Please rebase on develop to resolve it.
  2. CLA not signed — the license/cla check is pending. Please sign the Contributor License Agreement so CI can run.

Once both are resolved this is ready to merge.

@TechWizard9999 TechWizard9999 force-pushed the fix/rewrite-pnpm-lint-to-rtk-pnpm-lint branch from 508bfda to 5885789 Compare March 30, 2026 03:21
@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Thanks for the review update. I have rebased this branch on the latest develop and force-pushed to retrigger CI.

CLA recheck was also triggered again.

@FlorianBruniaux please re-review when convenient.

@morellodev
Copy link
Copy Markdown

Hi all, this PR fixes an annoying issue. @TechWizard9999 thanks a lot for submitting this! Are there other blockers that prevent this from being merged?

@TechWizard9999 TechWizard9999 force-pushed the fix/rewrite-pnpm-lint-to-rtk-pnpm-lint branch from 5885789 to 550becd Compare April 15, 2026 14:07
@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Thanks for the ping. I rebased this branch again on the latest develop, resolved the new refactor conflicts, and force-pushed a clean update just now.\n\nFrom my side there are no remaining code changes requested; waiting on maintainer review/merge. @pszymkowiak @FlorianBruniaux please recheck when convenient.

@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Quick maintainer ping after latest conflict resolution. @pszymkowiak @FlorianBruniaux please re-review when convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants