fix(rewrite): route pnpm lint through rtk pnpm#678
fix(rewrite): route pnpm lint through rtk pnpm#678TechWizard9999 wants to merge 2 commits intortk-ai:developfrom
Conversation
c7d146e to
1b17d79
Compare
|
@pszymkowiak could you please review this and let me know if anything needs to change? |
|
Any movement on this? |
|
Thanks for checking in, Joe. This PR is ready from my side: the branch was cleaned and scoped to only the intended fix, and CLA recheck was also triggered. @pszymkowiak could you please re-review when you have a moment? |
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
1b17d79 to
508bfda
Compare
|
Rebased on latest develop per the refactor notice and force-updated this branch. @pszymkowiak could you please re-review when convenient? |
|
The routing fix is correct and the regex change is sound. Two things blocking merge right now:
Once both are resolved this is ready to merge. |
508bfda to
5885789
Compare
|
Thanks for the review update. I have rebased this branch on the latest develop and force-pushed to retrigger CI. CLA recheck was also triggered again. @FlorianBruniaux please re-review when convenient. |
|
Hi all, this PR fixes an annoying issue. @TechWizard9999 thanks a lot for submitting this! Are there other blockers that prevent this from being merged? |
Signed-off-by: Roopesh <roopesh1724989@gmail.com>
5885789 to
550becd
Compare
|
Thanks for the ping. I rebased this branch again on the latest develop, resolved the new refactor conflicts, and force-pushed a clean update just now.\n\nFrom my side there are no remaining code changes requested; waiting on maintainer review/merge. @pszymkowiak @FlorianBruniaux please recheck when convenient. |
|
Quick maintainer ping after latest conflict resolution. @pszymkowiak @FlorianBruniaux please re-review when convenient. |
Description
Fixes rewrite routing for
pnpm lintso it no longer gets forced intortk lint(which can cause ESLint-oriented retry loops in non-ESLint projects).Related Issue
Closes #665
Changes Made
pnpm lintis recognized by thepnpmrule pathpnpm lintfromrtk lintrewrite prefixespnpm lint->rtk pnpm lintpnpm lint --fix->rtk pnpm lint --fixFiles Changed
src/discover/rules.rs- rewrite/classification adjustmentssrc/discover/registry.rs- regression tests for pnpm lint rewrite behaviorCHANGELOG.md- unreleased bug-fix note for pnpm lint causing issue when ESLint isn't used #665Testing
cargo fmt --all --checkrtk cargo clippy --all-targets(2 pre-existing warnings in untouched files)rtk cargo testrtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_routes_to_pnpmrtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_with_args_routes_to_pnpm./target/debug/rtk rewrite "pnpm lint"->rtk pnpm lintChecklist
cc @pszymkowiak for review