fix(ruby): use rails test for positional file args in rtk rake#741
Merged
aeppling merged 1 commit intortk-ai:developfrom Mar 20, 2026
Merged
Conversation
rake test ignores positional file arguments and only supports TEST=path for single-file runs. When users pass positional test files (e.g., `rtk rake test file1.rb file2.rb` or `rtk rake test file.rb:15`), select_runner() now switches to `rails test` which handles single files, multiple files, and line-number syntax natively. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nicholas Lee <nicholas.lee@appfolio.com>
Author
|
@pszymkowiak this fixes a small issue with #724 that was merged earlier today. |
Contributor
|
Hello, Thanks for this clean contribution, OK for me, code is explicit and tested |
aeppling
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rake testignores positional file arguments (e.g.,rtk rake test file1.rb file2.rb) and only supports single-file targeting viaTEST=path— this caused "no tests ran" or all tests running when users passed multiple filesselect_runner()that auto-switches torails testwhen positional test file paths are detected, sincerails testnatively handles single files, multiple files, and line-number syntax (file.rb:15)rake testis still used forTEST=path, flags-only, and no-args invocations (existing behavior preserved)Test plan
cargo fmt --all && cargo clippy --all-targets && cargo test— 1044 tests passrtk <command>output inspectedrtk rake test→ rake, 57 runs (all tests)rtk rake test TEST=file.rb→ rake, 1 runrtk rake test file.rb→ rails, 2 runs (just that file)rtk rake test file1.rb file2.rb→ rails, 3 runs (both files)rtk rake test file.rb:10→ rails, 1 run (specific line)select_runner()andlooks_like_test_path()