fix(dotnet): remove wrong flags add from rtk#745
Conversation
rtk was injecting --nologo and --logger flag, but those aren't always support in all environments. --nologo removed -> added for compress, but is failing, a compress should not make cmd fail --logger -> reformat the output for LLM, should not be done by rtk and is failing Signed-off-by: aesoft <43991222+aeppling@users.noreply.github.com>
e943472 to
35688e8
Compare
Signed-off-by: aesoft <43991222+aeppling@users.noreply.github.com>
|
#572 closing this issue on merge |
|
I don't think this is valid. The entire premise of the test parsing simplification is having a try file and at first glance this seems to be removing it (but I need to have a closer look) |
|
I now understand the change better. I think this introduceds a regression. Classic VSTest projects will lose the auto-injected trx logger which means RTK falls back to text parsing rather than structure TRX data. That's a degradation of the previously introduced functionality. The right solution is conditional injection based on MTP detection rather than all-or-nothing. I can send in a draft PR |
|
See #746 |
|
After looking at your PR i'm ok with your fix, keeping the flag and detecting whether or not we should inject those flags. I'm closing this one, we'll move to discuss on #746 Thanks Daniel, |
rtk was injecting --nologo and --logger flag, but those aren't always support in all environments.
--nologo removed -> added for compress, but is failing, a compress should not make cmd fail
--logger -> reformat the output for LLM, should not be done by rtk and is failing
Summary
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected