Skip to content

Copilot windows support#772

Closed
timeshift92 wants to merge 2 commits intortk-ai:masterfrom
timeshift92:copilot-windows-support
Closed

Copilot windows support#772
timeshift92 wants to merge 2 commits intortk-ai:masterfrom
timeshift92:copilot-windows-support

Conversation

@timeshift92
Copy link
Copy Markdown

Summary

Test plan

  • cargo fmt --all && cargo clippy --all-targets && cargo test
  • Manual testing: rtk <command> output inspected

Important: All PRs must target the develop branch (not master).
See CONTRIBUTING.md for details.

Ахмедов Нурбек Медетбаевич and others added 2 commits March 21, 2026 23:39
Add explicit GitHub Copilot integration for both repository-local and global setup, wire the Copilot hook asset to 
tk hook copilot, document the new workflow, and add focused tests for the new assets and CLI parsing.

Also fix the Windows startup stack overflow by reserving a larger main-thread stack at link time so 
tk.exe --version, --help, and Copilot hook entry points start reliably on Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ахмедов Нурбек Медетбаевич seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added effort-large Plusieurs jours, nouveau module enhancement New feature or request labels Mar 21, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟡 Risk medium

Summary

Adds GitHub Copilot support for RTK on Windows and other platforms. Introduces a new --agent copilot flag for rtk init, Windows-native hook scripts (.cmd), PowerShell command support, Copilot session discovery, and cross-platform path handling throughout the codebase.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

@pszymkowiak
Copy link
Copy Markdown
Collaborator

Closing as duplicate of #771 — same author, same feature. Copilot support is already shipped in v0.31.0.

The Windows stack fix has been extracted to issue #855 — feel free to submit a focused PR for that.

@pszymkowiak pszymkowiak added duplicate This issue or pull request already exists resolved-pending-close Answered/resolved — will close if no response labels Mar 26, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

Hi! Two things needed before we can review:

  1. Retarget to develop — this PR targets master, but all PRs should target develop. You can change the base branch in the PR settings (right sidebar).
  2. Sign the CLA — if not already done, please sign at https://cla-assistant.io/rtk-ai/rtk

Thanks!

@aeppling
Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

@timeshift92
Copy link
Copy Markdown
Author

#865 added new pr where i stay only stack info for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists effort-large Plusieurs jours, nouveau module enhancement New feature or request resolved-pending-close Answered/resolved — will close if no response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants