fix(discover): expand rules coverage for git, kubectl, jq and ignore ln#895
Closed
fkztw wants to merge 1 commit intortk-ai:developfrom
Closed
fix(discover): expand rules coverage for git, kubectl, jq and ignore ln#895fkztw wants to merge 1 commit intortk-ai:developfrom
fkztw wants to merge 1 commit intortk-ai:developfrom
Conversation
- Expand git PATTERN to include checkout, switch, remote, config, ls-files, tag, merge, rebase, reset, clean, clone, init, submodule, cherry-pick, revert, rm, mv, bisect, blame, reflog, shortlog, describe, archive, bundle, notes — all already supported via external_subcommand passthrough - Expand kubectl PATTERN to include create, delete, edit, scale, rollout, top, port-forward, config, exec, run, patch, label, annotate, explain, auth — all already supported via external_subcommand passthrough - Add jq to PATTERNS and RULES — the TOML filter (src/filters/jq.toml) already existed but was missing from discover rules, preventing hook rewrite and discover reporting - Add ln to IGNORED_PREFIXES — trivial filesystem operation that should not appear in unhandled commands
KuSh
reviewed
Mar 28, 2026
| r"^trunk\s+build", | ||
| r"^uv\s+(sync|pip\s+install)\b", | ||
| r"^yamllint\b", | ||
| // jq — TOML filter exists (src/filters/jq.toml) but was missing from discover |
KuSh
reviewed
Mar 28, 2026
| "if ", | ||
| "case ", | ||
| "ln ", | ||
| "ln\t", |
There was a problem hiding this comment.
I'm not sure this should be added. Tab is a completion key in most terminals, it shouldn't be easy to use it in command lines and I'm not sure LLM would use it either.
If it's a real case however, this should be handled globally and not just for that particular command
KuSh
suggested changes
Mar 28, 2026
KuSh
reviewed
Mar 28, 2026
| // Patterns ordered to match RULES indices exactly. | ||
| pub const PATTERNS: &[&str] = &[ | ||
| r"^git\s+(?:-[Cc]\s+\S+\s+)*(status|log|diff|show|add|commit|push|pull|branch|fetch|stash|worktree)", | ||
| r"^git\s+(?:-[Cc]\s+\S+\s+)*(status|log|diff|show|add|commit|push|pull|branch|fetch|stash|worktree|checkout|switch|remote|config|ls-files|tag|merge|rebase|reset|clean|clone|init|submodule|cherry-pick|revert|rm|mv|bisect|blame|reflog|shortlog|describe|archive|bundle|notes)", |
There was a problem hiding this comment.
Could you sort commands in alphabetical order to ease maintenance burden 🙏
Author
|
Closing this PR after reviewing the feedback and checking open PRs. Overlaps found:
What isn't covered elsewhere: The kubectl expansion and Apologies for the noise — should have checked open PRs before submitting. Thank you for the clear review @KuSh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands the token savings discovery coverage (
rtk discover) for several common command line patterns:git: Broadened matching criteria to accurately capture complex arguments includinggit clone,git commit -am, and strings wrapped in quotes.kubectl: Enhanced support to detect multi-flag statements typical in Kubernetes operational manifests.jq: Corrected the filter assignment to properly resolve coverage savings calculations forjqqueries.ln: Added the local link command to the global ignore list (IGNORED_PREFIXES), to prevent trivial commands from cluttering standard output optimization reports.