Allow dcp to respond to identify all filter types #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEC 61158-6-10:2019 4.3.1.2 specifies that an identify filter packet can contain 1 or more filter blocks and that any block type can be first. p-net determines that an identify packet is a filter, if the first block is a station name or alias filter block. This fixes pf_dcp_identify_req () so that p-net responds to single or multiple identify filter packets that start any supported filter type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IEC 61158-6-10:2019 4.3.1.2 specifies that an identify filter packet can
contain 1 or more filter blocks and that any block type can be first.
p-net determines that an identify packet is a filter, if the first block is
a station name or alias filter block.
This fixes pf_dcp_identify_req () so that p-net responds to single or
multiple identify filter packets that start any supported filter type.