bumbing up versions to remove vulnerabilites #47
Conversation
* Update README.md * Redis credentials (#44) * Update issue templates * OSS (#42) * removing sensitive information for opensourcing the project * add chart for deploying phoenix * remove hardcoded port * Update README.md * Create docker-publish.yml * Update README.md * Update README.md * Create LICENSE * Update README.md * Guidelines (#43) * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Update README.md * Update README.md * Create USERS.md * Update README.md * Update README.md * bump redis client version, add DB_PASSWORD for redis password, fix worker queue * typo in error checking * add new ENV to chart Co-authored-by: Niels ten Boom <nielstenboom@gmail.com> * remove default password from tests and cli Co-authored-by: Niels ten Boom <nielstenboom@gmail.com>
* add missing nodeselectors + fixed wrong refs * proper line endings
bjornm82
requested review from
bnguyennhon,
csimplestring,
nielstenboom and
volhakurylionak
| FROM alpine:3.9 | ||
| FROM alpine:3.13 | ||
| COPY --from=builder /app /app | ||
|
|
There was a problem hiding this comment.
could it be possible to also create & use a non-root user for the runtime image ?
There was a problem hiding this comment.
I was under the assumption we were not running with Alpine, seems weird we don't actually run a scratch image. You know the reason @nielstenboom ?
There was a problem hiding this comment.
No clue, all Davide's work from a long while ago
There was a problem hiding this comment.
Would it make sense to move to a scratch image in stead of alpine? I think it's overkill to use an OS for Go.
There was a problem hiding this comment.
make sense to me. A Scratch image is more secured at least (you have no extra deps)
There was a problem hiding this comment.
LGTM 👍 , let's see if the full integration tests run after it's merged: https://ci.freemium.diw.rtlwecloudservices.nl/teams/main/pipelines/phoenix-dev/jobs/test-build-and-push-image/builds/2
Bumping up versions to remove vulnerabilities
Currently on master:
Tested 171 dependencies for known issues, found 3 issues, 13 vulnerable paths.
This branch:
✓ Tested 221 dependencies for known issues, no vulnerable paths found.
TODO: Chart templates has some medium issues, won't be solved with this PR