chore: add download max retries parameter to environment variables

[sEpt0r]

What

This adds a new configuration parameter DOWNLOAD_MAX_RETRIES, which can be set via an environment variable instead of using the hardcoded limit of three download attempts.

Why

After testing in slower, “homelab-like” environments, I found that three attempts are sometimes not enough to complete the planet download. This change allows to increase the number of retry attempts by setting the environment variable in the container.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider converting and validating DOWNLOAD_MAX_RETRIES as an integer in your config module (with a fallback or warning on invalid values) so that the rest of your code can assume the type is correct.
• You may want to preserve the max_retries parameter in download_file’s signature (e.g. max_retries=None) to avoid breaking any existing calls or tests that rely on passing a custom retry count.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider converting and validating DOWNLOAD_MAX_RETRIES as an integer in your config module (with a fallback or warning on invalid values) so that the rest of your code can assume the type is correct.
- You may want to preserve the max_retries parameter in download_file’s signature (e.g. max_retries=None) to avoid breaking any existing calls or tests that rely on passing a custom retry count.

## Individual Comments

### Comment 1
<location> `src/downloader.py:505` </location>
<code_context>
-def download_file(url, destination, max_retries=3):
+def download_file(url, destination):
     start_time = time.time()
+    max_retries = int(config.DOWNLOAD_MAX_RETRIES)

     for attempt in range(max_retries):
</code_context>

<issue_to_address>
**suggestion:** Consider validating DOWNLOAD_MAX_RETRIES for non-integer or negative values.

Non-integer or negative values for DOWNLOAD_MAX_RETRIES may cause errors or unexpected behavior. Adding validation or a default fallback will improve robustness.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider validating DOWNLOAD_MAX_RETRIES for non-integer or negative values.

Non-integer or negative values for DOWNLOAD_MAX_RETRIES may cause errors or unexpected behavior. Adding validation or a default fallback will improve robustness.

[rtuszik]

Thanks for this one as well. Totally forgot about this, my bad!

[binnichtaktiv]

After testing in slower, “homelab-like” environments, I found that three attempts are sometimes not enough to complete the planet download.

Thanks for this PR I had the exact same problem!