Tweak unpackRepo(), allow specifying an explicit Path for the resource
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource The `unpackRepo()` method is very useful for setting up example repo fixtures for testing - it unzips zipped git archives on the resource classpath, and returns us the JGit repository. However, loading resources from the classpath (while convenient, meaning we don't need to worry about the absolute location on the filesystem of the zip file) can also be temperamental, with the resource not being found if it's not within the same classloader as the class of `com.madgag.git.test`. It seems the most reliable way to be able to find our test resources is to specify _which_ class we want to search the classpath of when we search for the resource. From there, we can get an unambiguous path for the resource that can be used by `unpackRepo()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unpackRepo()method is very useful for setting up example repo fixtures for testing - it unzips zipped git archives on the resource classpath, and returns us the JGit repository. However, loading resources from the classpath (while convenient, meaning we don't need to worry about the absolute location on the filesystem of the zip file) can also be temperamental, with the resource not being found if it's not within the same classloader as the class ofcom.madgag.git.test.It seems the most reliable way to be able to find our test resources is to specify which class we want to search the classpath of when we search for the resource. From there, we can get an unambiguous path for the resource that can be used by
unpackRepo().