Make multi-stream disconnect callbacks mutually exclusive#12
Merged
andriytyurnikov merged 1 commit intodevelopfrom Apr 27, 2026
Merged
Make multi-stream disconnect callbacks mutually exclusive#12andriytyurnikov merged 1 commit intodevelopfrom
andriytyurnikov merged 1 commit intodevelopfrom
Conversation
stream_one's lifecycle contract (handling_sync_errors) fires exactly one of on_server_disconnect / on_client_disconnect / on_error per stream — never a combination. stream_many violated this: its ensure block always fired on_server_disconnect, even when an error or client disconnect had already triggered the matching callback. Consumers writing observability/cleanup logic against these callbacks would see different behavior depending on whether they called .stream once or many times — a subtle source of bugs. Fix: track a completed_normally flag in stream_many's control thread, set it false when handle_streaming_error runs, and only fire on_server_disconnect in the ensure block when the flag is still true. 2 new shared examples (run for both ThreadExecutor and AsyncExecutor): - streamer raises → on_error fires, on_server_disconnect doesn't - client disconnects → on_client_disconnect fires, on_server_disconnect doesn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens previously-merged #6 after develop reset. See #6 for full description.