fix possible NRE

Author: retailcoder

Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousPredeclaredInstanceAccessInspection.cs

@@ -51,14 +51,12 @@ public SuspiciousPredeclaredInstanceAccessInspection(IDeclarationFinderProvider
 
         protected override bool IsResultReference(IdentifierReference reference, DeclarationFinder finder)
         {
-            if (!(reference.Declaration is ClassModuleDeclaration module) || 
-                !module.HasPredeclaredId ||
-                !reference.ParentScoping.ParentDeclaration.Equals(module))
-            {
-                return false;
-            }
-
-            return reference.IdentifierName != Tokens.Me;
+            return 
+                reference.Declaration is ClassModuleDeclaration module && 
+                module.HasPredeclaredId &&
+                reference.ParentScoping.ParentDeclaration.Equals(module) &&
+                reference.Context.TryGetAncestor<VBAParser.LExpressionContext>(out var expression) &&
+                reference.IdentifierName != Tokens.Me && expression.GetText() == reference.IdentifierName;
         }
 
         protected override string ResultDescription(IdentifierReference reference)

RubberduckTests/Inspections/SuspiciousPredeclaredInstanceAccessInspectionTests.cs

@@ -79,6 +79,22 @@ End Sub
             Assert.AreEqual(0, inspectionResults.Count());
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void NoMemberAccess_NoResult()
+        {
+            var className = "UserForm1";
+            var code = $@"
+Attribute VB_PredeclaredId = True
+Public AnyField As Long
+Private Sub Test()
+    If Me Is UserForm1 Then Exit Sub
+End Sub
+";
+            var inspectionResults = InspectionResultsForModules((className, code, ComponentType.UserForm));
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
         protected override IInspection InspectionUnderTest(RubberduckParserState state)
         {
             return new SuspiciousPredeclaredInstanceAccessInspection(state);