Hotkey leak #3676
Description
It was originally observed in PR #3670 and verified in the current next branch that we seem to be leaking hotkeys. Note that we recently modified the hotkey to be more compliant with Win32 API documentation in the PR #3663.
We register hotkeys when we get a focus message and unregister them when we get a kill focus message via the subclassing of the tool windows.
However, investigation shows that they are in fact registered, yet we are getting told that they weren't registered. Here's the debug output:
Note: error #1491 is ERROR_HOTKEY_NOT_REGISTERED and #6 is ERROR_INVALID_HANDLE.
Added handler for: Custom Popup 112045643 'Go to &implementation...' (tag: Project Window::RubberduckMenu::FindAllImplementationsCommandMenuItem, hashcode:16367560)
2018-01-06 10:32:57.6205;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand was registered with id 49265;
2018-01-06 10:32:57.6205;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.Refactorings.RefactorEncapsulateFieldCommand was registered with id 49284;
2018-01-06 10:32:57.6205;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.Refactorings.RefactorExtractMethodCommand was registered with id 49269;
2018-01-06 10:32:57.6205;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.Refactorings.RefactorMoveCloserToUsageCommand was registered with id 49273;
2018-01-06 10:32:57.6205;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.CodeExplorerCommand was registered with id 49274;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.ExportAllCommand was registered with id 49275;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.FindSymbolCommand was registered with id 49276;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.IndentCurrentModuleCommand was registered with id 49277;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.IndentCurrentProcedureCommand was registered with id 49278;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.InspectionResultsCommand was registered with id 49279;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.ReparseCommand was registered with id 49280;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.SourceControlCommand was registered with id 49266;
2018-01-06 10:32:57.6295;TRACE;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.TestExplorerCommand was registered with id 49264;
2018-01-06 10:32:57.6515;INFO;Rubberduck.UI.Command.VersionCheckCommand;Executing version check.;
'MSACCESS.EXE' (CLR v4.0.30319: DefaultDomain): Loaded 'C:\GitHub\Rubberduck\Rubberduck\RetailCoder.VBE\bin\Debug\HtmlAgilityPack.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
2018-01-06 10:32:57.9835;TRACE;Rubberduck.UI.CustomComWrappers.Wrapper_IOleClientSite;IOleInPlaceSite::OnPosRectChange() called;
2018-01-06 10:32:58.2386;TRACE;Rubberduck.UI.CustomComWrappers.Wrapper_IOleClientSite;IOleInPlaceSite::OnPosRectChange() called;
System.Windows.Data Error: 2 : Cannot find governing FrameworkElement or FrameworkContentElement for target element. BindingExpression:(no path); DataItem=null; target element is 'DataGridTemplateColumn' (HashCode=53379839); target property is 'SortDirection' (type 'Nullable`1')
2018-01-06 10:32:58.3936;TRACE;Rubberduck.VBEditor.SafeComWrappers.SafeComWrapper`1;Released COM wrapper of type Rubberduck.VBEditor.SafeComWrappers.VBA.VBProjects with remaining reference count 1.;
2018-01-06 10:32:58.3936;TRACE;Rubberduck.VBEditor.SafeComWrappers.SafeComWrapper`1;Released COM wrapper of type Rubberduck.VBEditor.SafeComWrappers.VBA.VBProjects with remaining reference count 1.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49265 for command of type Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49265 and the type of the associated command Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49284 for command of type Rubberduck.UI.Command.Refactorings.RefactorEncapsulateFieldCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49284 and the type of the associated command Rubberduck.UI.Command.Refactorings.RefactorEncapsulateFieldCommand.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49269 for command of type Rubberduck.UI.Command.Refactorings.RefactorExtractMethodCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49269 and the type of the associated command Rubberduck.UI.Command.Refactorings.RefactorExtractMethodCommand.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49273 for command of type Rubberduck.UI.Command.Refactorings.RefactorMoveCloserToUsageCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49273 and the type of the associated command Rubberduck.UI.Command.Refactorings.RefactorMoveCloserToUsageCommand.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49274 for command of type Rubberduck.UI.Command.CodeExplorerCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49274 and the type of the associated command Rubberduck.UI.Command.CodeExplorerCommand.;
2018-01-06 10:33:09.4267;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49275 for command of type Rubberduck.UI.Command.ExportAllCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49275 and the type of the associated command Rubberduck.UI.Command.ExportAllCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49276 for command of type Rubberduck.UI.Command.FindSymbolCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49276 and the type of the associated command Rubberduck.UI.Command.FindSymbolCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49277 for command of type Rubberduck.UI.Command.IndentCurrentModuleCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49277 and the type of the associated command Rubberduck.UI.Command.IndentCurrentModuleCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49278 for command of type Rubberduck.UI.Command.IndentCurrentProcedureCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49278 and the type of the associated command Rubberduck.UI.Command.IndentCurrentProcedureCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49279 for command of type Rubberduck.UI.Command.InspectionResultsCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49279 and the type of the associated command Rubberduck.UI.Command.InspectionResultsCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49280 for command of type Rubberduck.UI.Command.ReparseCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49280 and the type of the associated command Rubberduck.UI.Command.ReparseCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49266 for command of type Rubberduck.UI.Command.SourceControlCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49266 and the type of the associated command Rubberduck.UI.Command.SourceControlCommand.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling UnregisterHotKey on hokey with id 49264 for command of type Rubberduck.UI.Command.TestExplorerCommand; the error was 1419; going to delete the atom anyway... The memory may leak.;
2018-01-06 10:33:09.4387;WARN;Rubberduck.Common.Hotkeys.Hotkey;Error calling DeleteGlobalAtom; the error was 6, the id 49264 and the type of the associated command Rubberduck.UI.Command.TestExplorerCommand.;