Review inspection types

[retailcoder]

New inspections default to CodeQualityIssues if I recall correctly, and because it's easy to forget to review/set the InspectionType when creating a new inspection, many aren't under the right/intended category.

We need to review all inspection types, and perhaps...

• Rename MaintenanceAndReadability to NamingAndConventions
• Add a Performance inspection type
• Add a Miscellaneous or Uncategorized inspection type and make it the default to compel proper/explicit categorization

[GmausDev]

Hi ! i try to take it

[GmausDev]

Just send the Commit , i have a doubt over the last requirement . Normally when u have an Enum u can put a default value thats what u want?

[Vogel612]

@GmausDev that commit will not work, since all the references to the enum elements will also need to be adjusted. I highly recommend setting up a "proper" IDE for this

[GmausDev]

Hi , i had vss 2022 enterprise version. Im looking all the references let me a moment :p

[GmausDev]

There is no reference to the value who i´ve changed . Maybe any problem with the interface or the models?

[retailcoder]

Unfortunately this repo doesn't build with VS 2022 for some reason (works fine in VS 2019 though).

Inspection default configs are admittedly a bit of a mess - what appears on the website is being parsed from a decoded sub-section of this file: https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings

But the InspectionType strings need to match the InspectionType enum values.

[GmausDev]

Ahaha, okay . No worries I´ll open with vs2019. And i try to change the settings document . The enum change its fine? If i understand good now i must change the references of the settings.

[retailcoder]

I'd expect all the enum members to be at least used once for mapping to a particular icon asset somewhere... I think it's much safer to rename the members with a proper Rename refactoring in Visual Studio 😉