fix tests #1092
fix tests #1092
Conversation
|
|
||
| public override void Fix() | ||
| { | ||
| var oldContent = Context.GetText(); |
There was a problem hiding this comment.
If the context spans the entire body, this fix is now rewriting the entire thing and deleting all comments in the process, when really all that's needed is adding Public in front of the first token. Seems overkill and potentially irritating, I merged this PR because it fixes the tests, but clearly at least one test is missing for this inspection/fix, since it does not behave at it should - it's way too invasive for what it's doing.
There was a problem hiding this comment.
Is it just me or is this fixable by getting comments into the ParseTree as nodes?
That would allow skipping irrelevant content or rather readding it correctly
|
@Vogel612 indeed, if comments were in the parse tree it wouldn't be a problem, other than still being a bit overkill to rewrite the whole entire procedure only to stick |
|
I didn't know that about the comments, sorry! Thanks for fixing it. |
2 participants
The Declaration.Selection is the ambiguousidentifier's selection which is always only the first line. That's why this fix uses the procedure's context which spans the entire procedure which is what we probably want here.