Fix loading serialized declarations from non standard path #4239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #4239 +/- ##
==========================================
- Coverage 52.16% 52.14% -0.02%
==========================================
Files 968 968
Lines 33483 33484 +1
==========================================
- Hits 17466 17459 -7
- Misses 16017 16025 +8
|
Vogel612
reviewed
Jul 29, 2018
| using (var state = parser.State) | ||
| { | ||
| state.AddTestLibrary("Excel.1.8.xml"); | ||
| //state.AddTestLibrary("Excel.1.8.xml"); |
There was a problem hiding this comment.
why is this only commented out?
There was a problem hiding this comment.
Oh, I must have missed to completely remove.
| using (var state = parser.State) | ||
| { | ||
| state.AddTestLibrary("Excel.1.8.xml"); | ||
| //state.AddTestLibrary("Excel.1.8.xml"); |
There was a problem hiding this comment.
why is this only commented out?
| var parser = MockParser.Create(vbe.Object); | ||
|
|
||
| parser.State.AddTestLibrary(library.Equals("Scripting") ? "Scripting.1.0.xml" : "Excel.1.8.xml"); | ||
| //parser.State.AddTestLibrary(library.Equals("Scripting") ? "Scripting.1.0.xml" : "Excel.1.8.xml"); |
MDoerner
deleted the
FixLoadingSerializedDeclarationsFromNonStandardPath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4182
Moreover, the fix makes
MockParser.AddTestLibraryobsolete since the parsing process will pick up all serialized declarations from referenced projects. Acordingly, I removed it along with all uses.This had a good effect on test execution times.