Fix various bugs - Especially centered around the InspectionResults toolwindow #4984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring an inspection type no longer triggers a full reparse. Grouping behaviour changes are in a defer-cycle to avoid a rerender without any grouping.
This clarifies which resources are used where.
retailcoder
reviewed
Jun 4, 2019
| <ToggleButton Style="{StaticResource ToolBarToggleStyle}" | ||
| ToolTip="{Resx ResxName=Rubberduck.Resources.RubberduckUI, Key=GroupingStyle_BySeverity}" | ||
| IsChecked="{Binding Path=Grouping, Converter={StaticResource GroupBySeverityConverter}, ConverterParameter={x:Static codeInspections:InspectionResultGrouping.Severity}}"> | ||
| IsChecked="{Binding Path=Grouping, Converter={StaticResource GroupingToBooleanConverter}, ConverterParameter={x:Static codeInspections:InspectionResultGrouping.Severity}}"> |
There was a problem hiding this comment.
no. This just removes duplication in the converter instances used. Toolwindow now has 6 converters less associated with it.
retailcoder
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these commits should basically be it's own PR, but the changes are somewhat insignificant, so I've bundled them.
Could be merged as is.