Skip to content

Conversation

Hosch250
Copy link
Member

No description provided.

retailcoder and others added 30 commits December 11, 2015 10:03
… implementations. Unable to test as parse seems to break on interfaces.
German translations for source control panel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even go so far to try and get Keystrokes (or multi-step-keys) into a configuration based mapping, something like a properly encapsuled Dictionary<Keystroke, Command>. Hardcoding this doesn't seem like a viable option to me

Maybe that's only for a next step, though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't mine. It is from @retailcoder's Smart Indenter branch and is thoroughly broken (that is why it is commented out lower down and never initialized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cough for some values of "thoroughly broken" 😉

@Vogel612 that's precisely the plan 😄 ...I happened to bump into some difficulties putting it all together. Hotkeys are correctly captured and update the "status bar", but the Ctrl/Shift modifiers "stick" and the 2nd key becomes impossible to capture, not to mention how annoying it becomes to have Ctrl/Shift "stuck". As for the low-level keyboard hook, it works but tends to destabilize the whole environment and has been identified as a source of unexpected crashes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some values of "unexpected crashes". It crashes Excel every time I open the VBE with that code uncommented.

@retailcoder
Copy link
Member

I'll merge this one later, apparently there are conflicts.. cannot merge from phone.. @ckuhn203 @Hosch250 feel free to merge it

Hosch250 added a commit that referenced this pull request Dec 20, 2015
@Hosch250 Hosch250 merged commit 0239dca into rubberduck-vba:next Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants