-
Notifications
You must be signed in to change notification settings - Fork 315
Promote local to parameter #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote local to parameter #878
Conversation
Smart indenter
Smart indenter
… implementations. Unable to test as parse seems to break on interfaces.
… resolved, so I can't test it.
…English and German
German translations for source control panel
Smart indenter
Smart indenter
…duck into PromoteLocalToParameter
RetailCoder.VBE/App.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd even go so far to try and get Keystrokes (or multi-step-keys) into a configuration based mapping, something like a properly encapsuled Dictionary<Keystroke, Command>
. Hardcoding this doesn't seem like a viable option to me
Maybe that's only for a next step, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That isn't mine. It is from @retailcoder's Smart Indenter branch and is thoroughly broken (that is why it is commented out lower down and never initialized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cough for some values of "thoroughly broken" 😉
@Vogel612 that's precisely the plan 😄 ...I happened to bump into some difficulties putting it all together. Hotkeys are correctly captured and update the "status bar", but the Ctrl/Shift modifiers "stick" and the 2nd key becomes impossible to capture, not to mention how annoying it becomes to have Ctrl/Shift "stuck". As for the low-level keyboard hook, it works but tends to destabilize the whole environment and has been identified as a source of unexpected crashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some values of "unexpected crashes". It crashes Excel every time I open the VBE with that code uncommented.
I'll merge this one later, apparently there are conflicts.. cannot merge from phone.. @ckuhn203 @Hosch250 feel free to merge it |
No description provided.