Support timestamp 'versions' by falling back to string comparison when to VersionInts() are equal#25
Merged
rubenv merged 4 commits intorubenv:masterfrom Jun 14, 2016
Merged
Conversation
added 4 commits
March 1, 2016 14:09
…to string comparison when VersionInt() of two migration steps are equal.
Owner
|
Cool, thanks! Sorry for taking this long to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the two following migrations are considered to have the same version:
This happens because only the first number in the ID string is used for comparion, i.e.
20160126for both migrations. The patch fixes this by falling back to string comparsion whenMigration.VersionInt()returns the same version for two migrations.Also, generalize temporary filename used for
migration_test.goby usingioutil.TempFile()to create one.