Skip to content

Fix a false positive for RspecRails/NegationBeValid when use to_not #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

Fix a false positive for RspecRails/NegationBeValid when use to_not #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Master (Unreleased)

- Fix a false positive for `RspecRails/NegationBeValid` when use `to_not`. ([@ydah])

## 2.32.0 (2025-11-12)

- Add `RSpecRails/HttpStatusNameConsistency` cop. ([@taketo1113])
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/cop/rspec_rails/negation_be_valid.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class NegationBeValid < ::RuboCop::Cop::Base

# @!method not_to?(node)
def_node_matcher :not_to?, <<~PATTERN
(send ... :not_to (send nil? :be_valid ...))
(send ... {:not_to :to_not} (send nil? :be_valid ...))
PATTERN

# @!method be_invalid?(node)
Expand Down
8 changes: 8 additions & 0 deletions spec/rubocop/cop/rspec_rails/negation_be_valid_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@
RUBY
end

it 'registers an offense when using ' \
'`expect(...).to_not be_valid`' do
expect_offense(<<~RUBY)
expect(foo).to_not be_valid
^^^^^^^^^^^^^^^ Use `expect(...).to be_invalid`.
RUBY
end

it 'does not register an offense when using ' \
'`expect(...).to be_invalid`' do
expect_no_offenses(<<~RUBY)
Expand Down