Skip to content

Avoid non nil checks in examples #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2014
Merged

Avoid non nil checks in examples #341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89dc612
Keep line length to 80
yous Jul 24, 2014
d89aa5a
Avoid non-`nil` checks in examples
yous Jul 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ Translations of the guide are available in the following languages:
end
```

While several Ruby books suggest the first style, the second is much more prominent
in practice (and arguably a bit more readable).
While several Ruby books suggest the first style, the second is much more
prominent in practice (and arguably a bit more readable).

* <a name="no-trailing-backslash"></a>
Avoid line continuation `\` where not required. In practice, avoid using
Expand Down Expand Up @@ -1115,9 +1115,9 @@ Translations of the guide are available in the following languages:
names.select { |name| name.start_with?('S') }.map { |name| name.upcase }
```

Some will argue that multiline chaining would look OK with the use of {...}, but they should
ask themselves - is this code really readable and can the blocks' contents be extracted into
nifty methods?
Some will argue that multiline chaining would look OK with the use of {...},
but they should ask themselves - is this code really readable and can the
blocks' contents be extracted into nifty methods?

* <a name="block-argument"></a>
Consider using explicit block argument to avoid writing block literal that
Expand Down Expand Up @@ -2649,7 +2649,7 @@ Translations of the guide are available in the following languages:
rescue
# .. handle error
ensure
f.close unless f.nil?
f.close if f
end
```

Expand Down