Fix good & bad codes to equal #393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
This was intentional - you can bind the resulting value to any variable name.
Contributor
Author
There was a problem hiding this comment.
I did not notice that.
marocchino
force-pushed
the
code-equivalent
branch
from
dc4853f to
2c5dc24
Compare
Collaborator
|
Let me know when the PR is updated. |
Contributor
Author
|
I do not have permission to reopen PR.
anyway, how about this? |
Collaborator
|
I don't think that the extra comment is needed. Just fixing the first variable name is enough. |
Merged
Collaborator
|
What about the other part of this PR? (about |
Contributor
Author
|
I think It is not needed because there is similar PR (#381). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.