New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TLS 1.2 support for the PowerShell module #154

Merged
merged 3 commits into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@MikeFal
Contributor

MikeFal commented Jan 2, 2018

Description

Currently, PowerShell defaults to using TLS 1.0 for Invoke-WebRequest. This change forces use of TLS 1.2.

Related Issue

Fixes #153 RFE: TLS 1.2 support

Motivation and Context

If the Rubrik cluster disables TLS 1.0, the PowerShell module will stop working. Enforcing TLS 1.2 for the Rubrik PowerShell module solves this issue.

How Has This Been Tested?

Rubrik's SE-3 lab has TLS 1.0 disabled. With the updated module, Get-RubrikVM, Get-RubrikDatabase, and New-RubrikSnapshot were tested to validate no issues with connectivity.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Mike Fal added some commits Jan 2, 2018

Mike Fal
Updates for cleaner code.
- Removed TLS 1.2 force from Submit-Request (relying on TLS 1.2 to be added as part of the connect)
- Modified Connect-Rubrik to check for Tls12 in SecurityProtocol, add to existing protocols if not found.
@chriswahl

chriswahl approved these changes Jan 2, 2018 edited

Tested on my end. Works fine. :shipit:

@chriswahl chriswahl merged commit eaaa84e into master Jan 2, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@chriswahl chriswahl deleted the TLS12Support branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment