Adding TLS 1.2 support for the PowerShell module#154
Merged
Conversation
added 3 commits
January 2, 2018 11:59
- Removed TLS 1.2 force from Submit-Request (relying on TLS 1.2 to be added as part of the connect) - Modified Connect-Rubrik to check for Tls12 in SecurityProtocol, add to existing protocols if not found.
chriswahl
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, PowerShell defaults to using TLS 1.0 for Invoke-WebRequest. This change forces use of TLS 1.2.
Related Issue
Fixes #153 RFE: TLS 1.2 support
Motivation and Context
If the Rubrik cluster disables TLS 1.0, the PowerShell module will stop working. Enforcing TLS 1.2 for the Rubrik PowerShell module solves this issue.
How Has This Been Tested?
Rubrik's SE-3 lab has TLS 1.0 disabled. With the updated module, Get-RubrikVM, Get-RubrikDatabase, and New-RubrikSnapshot were tested to validate no issues with connectivity.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!