Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Conversation

@mwpreston
Copy link
Contributor

@mwpreston mwpreston commented Nov 3, 2020

Description

Modified generateCreds.ps1 to output rubrikCred.xml, vmwareCred.xml, and guestCred.xml rather than rubrikCreds.xml, vmwareCreds.xml, and guestCreds.xml

Modified quickstart.md to reflect those changes

Related Issue

Resolve Issue 12

Motivation and Context

All other code points to rubrikCred.xml, vmwareCred.xml, and guestCred.xml - this will alleviate the confusion for our end users.

How Has This Been Tested?

Tested locally

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwpreston mwpreston requested a review from jaapbrasser November 3, 2020 14:32
Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@jaapbrasser jaapbrasser merged commit 4512615 into master Nov 13, 2020
@jaapbrasser jaapbrasser deleted the mwp-issue12 branch November 13, 2020 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize Credential File Names

3 participants