fix(gameinput): 更新 InputWeave 修正版套件#40
Merged
Merged
Conversation
更新 repo-local InputWeave.GameInput 0.0.1 nupkg 的封裝來源與 SHA256,並讓 CI 與 release 驗證 nuspec commit,避免同版套件快取誤用舊 DLL。 新增 FunctionPtr marshaling 守門測試與工程文件規範,移除 InputBox 端相容 fallback 的假設,讓 GameInput 初始化失敗維持既有 XInput 退避路徑。
Contributor
There was a problem hiding this comment.
Pull request overview
此 PR 更新 repo-local InputWeave.GameInput 0.0.1 nupkg 的封裝來源 commit(72697db…)與 SHA256(451b9d65…),同步所有文字檔/workflow 中的引用;在 CI 與 release workflow 新增從 nupkg 解壓 .nuspec 並驗證 commit="…" 屬性的步驟,避免同版套件因 NuGet 快取沿用舊 DLL;新增 GameInputCallbackParameters_AreFunctionPointers 測試守門 IGameInput.Register*Callback 必須以 MarshalAs(UnmanagedType.FunctionPtr) 宣告;並在 docs/engineering/gamepad-api.md 補上 InputWeave callback interop 規範,明確禁止在 InputBox 端以 fallback 遮蔽 marshaling 錯誤,失敗時維持 GameInput 初始化失敗 + XInput 退避路徑。
Changes:
- 同步更新 InputWeave.GameInput nupkg 的 commit/SHA256 在 README、測試 README、license 文件、nupkg.sha256 及 CI/release workflow 內的引用。
- CI/release 新增 nuspec
commit="…"驗證步驟,並在 nuspec 缺失或 commit 不符時Write-Error。 - 新增 FunctionPtr marshaling 守門測試與 InputWeave callback 互通性工程文件規範。
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/nuget/InputWeave.GameInput.0.0.1.nupkg.sha256 | 更新為新封裝的 SHA256。 |
| eng/nuget/InputWeave.GameInput_LICENSE.txt | 來源/封裝來源/SHA256/授權檔案連結同步至新 commit。 |
| README.md | 第三方授權段同步 commit 與 SHA256。 |
| tests/InputBox.Tests/README.md | 測試數從 383→384,並同步 InputWeave 引用;新增 callback function pointer marshaling 描述。 |
| tests/InputBox.Tests/GameInputDirectUsageTests.cs | 新增 GameInputCallbackParameters_AreFunctionPointers 與其 reflection helper。 |
| docs/engineering/gamepad-api.md | 新增 InputWeave callback 互通性規範。 |
| .github/workflows/ci.yml | 解壓 nupkg 並驗證 .nuspec 內 commit="…"。 |
| .github/workflows/release.yml | 同上;同步 ThirdPartyNotices 內 commit/SHA256 字串。 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新 repo-local InputWeave.GameInput 0.0.1 nupkg 的封裝來源與 SHA256,並讓 CI 與 release 驗證 nuspec commit,避免同版套件快取誤用舊 DLL。 新增 FunctionPtr marshaling 守門測試與工程文件規範,移除 InputBox 端相容 fallback 的假設,讓 GameInput 初始化失敗維持既有 XInput 退避路徑。