Fix redis cache deletion#256
Merged
bmarkons merged 2 commits intoruby-bench:masterfrom Sep 7, 2017
Merged
Conversation
added 2 commits
September 7, 2017 17:23
We need to drop cache for every comparison chart.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When new run is being saved for certain benchmark, we want to invalidate cache for both comparison charts.
For example -- when new run for
pg/scope_allis received, we want to invalidate cache for both charts:https://rubybench.org/ged/ruby-pg/commits?result_type=pg/scope_all&display_count=2000&compare_with=activerecord/postgres_scope_all
and
https://rubybench.org/rails/rails/commits?result_type=activerecord/postgres_scope_all&display_count=2000&compare_with=pg/scope_all