Scan bookmarks in headers and footers (original idea by @bramj in #22)

[satoryu]

Summary

Extends Document#bookmarks to also scan headers and footers. Until now bookmarks were only collected from the document body (document.xml), so any bookmark placed in a header or footer was invisible to the API and could not be edited.

doc = Docx::Document.open("template.docx")

# previously: only body bookmarks; header/footer bookmarks were missing
doc.bookmarks["header_bookmark"].insert_text_after("ACME Corp ")
doc.bookmarks["footer_bookmark"].insert_text_after("Page footer ")
doc.save("filled.docx")   # edits persist (see #175)

Why this works

The existing Bookmark insertion API (insert_text_before / insert_text_after / insert_multiple_lines) is not body-specific — it operates on the bookmark's own Nokogiri node and creates new nodes in that node's document (element.node.document). Since #173 / #174 expose headers/footers as Nokogiri documents and #175 writes them back on save, scanning their bookmarks is enough to make header/footer bookmark editing fully round-trip. Verified end to end with a save/reopen test.

Changes

• bookmarks now appends w:bookmarkStart nodes found in headers.values and footers.values (keyed by name, same as the body). _GoBack filtering and name-keyed Hash semantics are unchanged.
• Adds fixture spec/fixtures/multi_doc_bookmarks.docx (a header_bookmark in the header and a footer_bookmark in the footer).
• Adds specs: scanning finds header/footer bookmarks, text insertion into both, and a save/reopen round-trip.

Note on behavior change

bookmarks now returns header/footer bookmarks in addition to body ones. Word bookmark names are document-unique, so collisions are unlikely; if a name does collide, last-write-wins in the order body → headers → footers. This is effectively a completeness fix.

Credit

Based on the original header-bookmark idea by @bramj in #22, extended here to also cover footers. They are credited as a co-author on the commit and should be credited in the release notes when this ships.

Tests

• Full suite green locally (145 examples, 0 failures).

Closes #22

🤖 Generated with Claude Code