Freeze rubocop version for stable CI#278
Merged
LeFnord merged 5 commits intoruby-grape:masterfrom Oct 31, 2017
kachick:fix-rubocop
Merged
Freeze rubocop version for stable CI#278LeFnord merged 5 commits intoruby-grape:masterfrom kachick:fix-rubocop
LeFnord merged 5 commits intoruby-grape:masterfrom
kachick:fix-rubocop
Conversation
Here's an example of a CHANGELOG.md entry: * [#278](https://github.com/ruby-grape/grape-entity/pull/278): Freeze rubocop version for stable ci - [@kachick](https://github.com/kachick).Generated by 🚫 danger |
Member
LeFnord
reviewed
Oct 31, 2017
| s.add_development_dependency 'bundler' | ||
| s.add_development_dependency 'rake' | ||
| s.add_development_dependency 'rubocop', '~> 0.48' | ||
| s.add_development_dependency 'rubocop', '~> 0.48.0' |
Contributor
Author
There was a problem hiding this comment.
So we need to add the line into Gemfile instead of gemspec, I think 🤔
Could you check 8895a69 ?
Member
There was a problem hiding this comment.
think you can remove this line
LeFnord
reviewed
Oct 31, 2017
| gemspec | ||
|
|
||
| group :development do | ||
| group :development, :test do |
Member
There was a problem hiding this comment.
it adds always 0.51 → maybe you have to remove the line in gem spec?
Contributor
Author
There was a problem hiding this comment.
it adds always 0.51
Yes, How about b66105f?
LeFnord
reviewed
Oct 31, 2017
| gemspec | ||
|
|
||
| group :development, :test do | ||
| gem 'rubocop', '~> 0.48.0', require: false |
| s.add_development_dependency 'bundler' | ||
| s.add_development_dependency 'rake' | ||
| s.add_development_dependency 'rubocop', '~> 0.48' | ||
| s.add_development_dependency 'rubocop', '~> 0.48.0' |
Member
There was a problem hiding this comment.
think you can remove this line
Member
|
I see … cool 👍 |
Member
|
please can you close the other PRs, think here is all in 😉 |
Contributor
Author
|
Thank you! Then, Can I close #279 ? ⏹ |
Contributor
Author
|
Oh sorry to misunderstood 🙇 And Thank you for the review! I'll update rest PRs 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: rubocop/rubocop@dd0d60c
#277 failed as https://travis-ci.org/ruby-grape/grape-entity/jobs/295161671 from rubocop 0.48~0.51 changes.