Add Danger CI checks for pull requests#400
Merged
Conversation
Replace ruby-grape-danger with danger-pr-comment to align with the grape repo's two-workflow approach: one workflow runs Danger, another posts the results as PR comments.
Sort danger gems alphabetically within the test group.
Inline breaking change marker, remove extra period in description, and add missing @ prefix to author link.
numbata
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s PR-check automation by switching the Danger setup from ruby-grape-danger to danger-pr-comment, matching the configuration used in the main grape repository, and adds a CHANGELOG enforcement check.
Changes:
- Replace
ruby-grape-dangerwithdanger-pr-commentand adddanger-changelog+changelog.check!. - Add GitHub Actions workflows to run Danger checks and then post results as PR comments.
- Update
CHANGELOG.mdentries to reflect the new PR-check approach and correct/normalize some historical entries.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Gemfile | Adds Danger-related gems and removes ruby-grape-danger. |
| Dangerfile | Imports danger-pr-comment checks and enforces CHANGELOG updates via changelog.check!. |
| CHANGELOG.md | Records the change and fixes/normalizes several entries. |
| .github/workflows/danger.yml | Adds a reusable-workflow-based Danger run on PR events. |
| .github/workflows/danger-comment.yml | Adds a workflow_run-based job to post Danger results as PR comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automate pull request quality checks by adding Danger to the CI pipeline. This ensures every PR follows project conventions — such as including a CHANGELOG entry — before it can be merged, reducing manual review burden and keeping the project consistent.
ruby-grape-dangertodanger-pr-comment, aligning with how grape handles PR checks