remote_ip method for request

[kushkella]

For Rails controllers there is remote_ip method to get client's ip. Can we have a similar method for Grape request?

[dblock]

Is env['REMOTE_ADDR'] what you want?

[kushkella]

Yeah but I want the ip of the remote client, the way it is calculated by ActionDispatch RemoteIP middleware. http://api.rubyonrails.org/classes/ActionDispatch/RemoteIp.html

[dblock]

I think Rack already provides this, how different is request.ip?

https://github.com/rack/rack/blob/master/lib/rack/request.rb#L348

[dblock]

Answered my own question: http://stackoverflow.com/questions/10997005/whats-the-difference-between-request-remote-ip-and-request-ip-in-rails

I think if you want the same implementation as RemoteIp in pure Rack, it should just be something that extends Rack::Request or a middleware that modifies what Rack::Request.ip returns. I am not convinced this should be part of Grape because this is more rack specific than Grape. Maybe you want to write a gem that does it (couldn't find one))?

What do you think?

[kushkella]

Grape Request class already extends Rack::Request, so why not add a method there? Similar to what Rails does.

[dblock]

I would look at a PR. My first reaction is that I don't want to confuse ip with is already there and is provided by rack, with some new client_ip method that is "almost the same thing". I also think it would be useful in general with Rack, so having that available is a win for everybody, then if we want that in Grape, we should add a dependency on that gem.

[kushkella]

I looked for issues related to this in Rack repo and found this rack/rack#598. I haven't really looked in depth where the ip method is used, but I'm pretty sure changing the return value of this method will mess up things. This is why Rails implemented a separate remote_ip method instead of overriding theip method. I'm of the view that the client_ip should be available for every request. And you are right that it should be available for all applications that run on Rack. I'll open an issue in the Rack repo and see what they think about this.

Thanks for the help.

[dblock]

I encourage you to just port the implementation in ActiveSupport into a separate gem.

I'll leave this open here as far as exposing it to Grape.

[aaronchi]

I would like to see this accessible to grape as well

[dspaeth-faber]

Is realy a gem needed or is documentation how you can use it sufficient?

Every body who wants this feature can add

  gem 'actionpack'

  class API < Grape::API
    require 'action_dispatch/middleware/remote_ip.rb'

    use ActionDispatch::RemoteIp, opts

    get '/test' do
       env["action_dispatch.remote_ip"].to_s()
    end
  end

And you have to keep in mind that with this methods

IF YOU DON'T USE A PROXY, THIS MAKES YOU VULNERABLE TO IP SPOOFING.

[dblock]

I would be glad to see this in the README under some section of how ActionDispatch middleware can be used inside Grape.