Extract Grape::Endpoint.before_each into Grape::Testing#2681
Open
ericproulx wants to merge 1 commit intomasterfrom
Open
Extract Grape::Endpoint.before_each into Grape::Testing#2681ericproulx wants to merge 1 commit intomasterfrom
ericproulx wants to merge 1 commit intomasterfrom
Conversation
Danger ReportNo issues found. |
Move before_each, reset_before_each, and run_before_each out of Grape::Endpoint and into an opt-in Grape::Testing module loaded via `require 'grape/testing'`. Production requests no longer pay any cost from this testing-only feature. RunBeforeEach is prepended into Endpoint#run and ClassMethods is extended onto Grape::Endpoint only when the testing module is required. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
extract_testing_module
branch
from
932b2b8 to
ba7386a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before_each,reset_before_each, andrun_before_eachout ofGrape::Endpointinto a new opt-inGrape::Testingmodulerun_before_eachis only injected intoEndpoint#runviaprependwhenrequire 'grape/testing'is calledbefore_eachnow always requires a block (raisesArgumentErrorotherwise);reset_before_eachreplaces the oldbefore_each(nil)patternlib/grape/endpoint.rbfromStyle/OptionalBooleanParameterrubocop todoTest plan
bundle exec rspec spec/grape/testing_spec.rb— new dedicated spec forGrape::Testingbundle exec rspec spec/grape/endpoint_spec.rb— verify no regression on endpoint behaviour🤖 Generated with Claude Code