Encapsulate Grape::Validations::Validators::Base state behind readers

[ericproulx]

Summary

Grape::Validations::Validators::Base exposed its state as bare instance variables that every subclass reached into directly (@options, @scope, @required, @allow_blank, @exception_message, @attrs, @fail_fast). This PR routes all internal reads through accessor methods so the ivars are an implementation detail, and gives the boolean attributes consistent ? predicates.

Pure internal refactor — no behavior change.

What changed

Base

• Added private attr_reader :options, :scope, :required, :allow_blank, :exception_message.

• :attrs stays a public attr_reader (left intentionally — making it private would be an externally observable change for third-party code calling validator.attrs).

• Boolean readers now have ? aliases, consistent with the existing fail_fast?:

  attr_reader :fail_fast, :options, :scope, :required, :allow_blank, :exception_message
  alias required?    required
  alias allow_blank? allow_blank
  alias fail_fast?   fail_fast
  public :fail_fast?

• fail_fast? was a hand-written def; it's now an attr_reader + alias like the others. Only attrs and fail_fast? stay public — they are the only readers that cross the validator boundary (Grape::Endpoint#run_validators calls validator.validate / validator.fail_fast?); everything else is now private.

Subclasses — every direct @ivar read replaced with the reader: default_validator, coerce_validator, multiple_params_base, values_validator, length_validator, oneof_validator, at_least_one_of_validator, all_or_none_of_validator. Two locals that would have shadowed the new readers were renamed (attrs → attributes in DefaultValidator#validate!, scope → current_scope in ValuesValidator#required_for_root_scope?).

The @option alias ivar (# TODO: remove in next major release) is deliberately left untouched — it's an externally-facing deprecated alias and folding it in is a separate decision.

Visibility (verified by introspection)

method	visibility
attrs, fail_fast?	public
fail_fast, options, scope, required, allow_blank, exception_message, required?, allow_blank?	private

Testing

• spec/grape/validations + spec/grape/endpoint_spec.rb: 795 examples, 0 failures
• RuboCop: clean

🤖 Generated with Claude Code

[github-actions]

Danger Report

No issues found.

View run