Replace JSON.load with JSON.parse in Grape::Json stdlib fallback#2761
Closed
dblock wants to merge 1 commit into
Closed
Replace JSON.load with JSON.parse in Grape::Json stdlib fallback#2761dblock wants to merge 1 commit into
dblock wants to merge 1 commit into
Conversation
JSON.parse is the semantically correct API for parsing untrusted input. JSON.load is intended for internal serialization of trusted data. Using create_additions: false merely neutered JSON.load to behave like JSON.parse — may as well use the right call directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix/json-use-parse
branch
from
7afd209 to
c02a82e
Compare
Danger ReportNo issues found. |
Contributor
|
I think this is better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2759.
JSON.parseis the semantically correct API for parsing untrusted input.JSON.loadis documented for internal serialization of trusted data (analogous toMarshal.load). The previous fix passedcreate_additions: falseto neuterJSON.load— but that just makes it behave likeJSON.parse. May as well use the right call directly.To me it looks strange that we'd overload
loadwithparse, so I think we don't merge this.