thor fixups and component/locale standardization

[movermeyer]

What are you trying to accomplish?

thor has changed the way that you specify options. I've refreshed our use of thor to match.
As part of this, I standardize the names used to refer to components and locales on the command line (and internally in the codebase).

What approach did you choose and why?

I arbitrarily picked the capital-case of the module names.
Before, you could specify CountryCodes, country-codes, or country_codes and all would work. There was no need to support this flexibility, so I picked one style to enforce. Now, only CountryCodes is valid.

I also arbitrarily picked the ruby-i18n version of locales codes (en-US instead of en_US)
Before, it was expecting CLDR versions of locale codes (e.g., en_US).
Standardizing on this format allowed me to remove some unnecessary calls to to_i18n.

Since type: array values don't yet get enum validation from thor, this validation of the inputs had to be done in ruby-cldr.

What should reviewers focus on?

🤷

There is only one change to the output of thor cldr:export, which was incorrectly outputting the wrong locale code:

diff -r before/pt-PT/plurals.rb after/pt-PT/plurals.rb
1c1
< { :'pt_PT' => { :i18n => { :plural => { :keys => [:one, :other], :rule => lambda { |n| n = n.respond_to?(:abs) ? n.abs : ((m = n.to_s)[0] == "-" ? m[1,m.length] : m); (n.to_i == 1 && ((v = n.to_s.split(".")[1]) ? v.length : 0) == 0) ? :one : :other } } } } }
\ No newline at end of file
---
> { :'pt-PT' => { :i18n => { :plural => { :keys => [:one, :other], :rule => lambda { |n| n = n.respond_to?(:abs) ? n.abs : ((m = n.to_s)[0] == "-" ? m[1,m.length] : m); (n.to_i == 1 && ((v = n.to_s.split(".")[1]) ? v.length : 0) == 0) ? :one : :other } } } } }
\ No newline at end of file

The impact of these changes

• Users will have to specify the capital-case versions of the component names when they use thor cldr:export.
• Users will have to specify the ruby-cldr version of the locale codes when they use thor cldr:export.
• When users use thor help cldr:export, the printout is much nicer, and relies on defaults that come from the constants actually used by the code.

Testing

thor cldr:export

See the new help docs with:

thor help cldr:download
thor help cldr:export