Export subdivisions#46
Merged
froyomuffin merged 1 commit intoruby-i18n:masterfrom Mar 26, 2019
Merged
Conversation
froyomuffin
force-pushed
the
export_subdivisions
branch
from
c55eefc to
c780ddd
Compare
Korri
requested changes
Mar 26, 2019
Collaborator
Korri
left a comment
Korri
left a comment
There was a problem hiding this comment.
You can remove the test fixed from that PR now as they are on master.
froyomuffin
force-pushed
the
export_subdivisions
branch
from
c780ddd to
e97bdfb
Compare
goldenson
reviewed
Mar 26, 2019
| end | ||
|
|
||
| # | ||
| # test "extract subdivisions for #{locale}" do |
Collaborator
Author
There was a problem hiding this comment.
Just following an existing pattern where we have this kind of tests commented out 🤷♂️. Honestly, I think we should just have something that runs all exports. It takes like 5 mins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exports the
subdivisions(provinces, states, prefectures etc) from CLDR. :)Essentially, we define a
SubdivisionsoffBaseand:pathsince subdivisions are defined off{root}/subdivisions/instead of{root}/main/docto no-op the case where the locale xml doesn't exist. This is an issue when we export subdivisions on all locales, we do so usingCldr::Export::Data.localeswhich is defined off of{root}/main/*. I'm still usingmainlocales as reference so I added a test to make sure thesubdivisionslocales <mainlocales.I also made some updates because of failing tests:
en-GBanden-USfromtest languages :desince those entries have been removed in CLDR 34ParentLocales.newprovides an argument (even if not used)