Output parent locales once#91
Merged
Korri merged 4 commits intoruby-i18n:masterfrom Nov 26, 2021
Merged
Conversation
117c7a6 to
c7b54c2
Compare
cejaekl
reviewed
Nov 26, 2021
Collaborator
cejaekl
left a comment
There was a problem hiding this comment.
FWIW, this looks good to me.
Korri
approved these changes
Nov 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #90
What approach did you choose and why?
ParentLocalesto the list of shared localesParentLocalesinCldr::Export::Data#components(effectively reverting Fix parent locales #40)When
ParentLocaleswas added, it was added as a locale-based component, but didn't have the same signature of locale-based components (since of course it is a shared component), so it caused an error. This was fixed in IMO the wrong way in #40, by excluding the component from being exported unless explicitly requested.This brings back the component, and now that it is properly marked as a shared component, it no longer has that error.
What should reviewers focus on?
🤷
The impact of these changes
ParentLocalesis once again exported by default (users ofruby-cldrno longer have to runthor cldr:exportandthor cldr:export --components=parentLocales, but instead just the former)parent_locales.ymlis output indata/and not under each locale directory.--components=parentLocales).ymlfilesTesting
See that
data/parent_locales.ymlexists and contains the same data.