WIP Add connection pool option #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarlemSquirrel
commented
Jul 25, 2020
| s.required_ruby_version = ">= 2.0.0" | ||
| s.summary = %q{Net::LDAP for Ruby (also called net-ldap) implements client access for the Lightweight Directory Access Protocol (LDAP), an IETF standard protocol for accessing distributed directory services} | ||
|
|
||
| s.add_runtime_dependency("connection_pool", "~> 2.2") |
Member
Author
There was a problem hiding this comment.
I'm not sure if we want to make this a requirement or allow users to opt in by adding the gem in their Gemfile. If we do that, then we have to handle when the library is missing.
| @encryption = normalize_encryption(args[:encryption]) # may be nil | ||
| @connect_timeout = args[:connect_timeout] | ||
| if args[:connection_pool].is_a? Hash | ||
| options = { size: 5, timeout: (@connection_timeout || 5) }.merge args[:connection_pool] |
Member
Author
There was a problem hiding this comment.
I'm not sure if we should default the timeout here in this way. The time to wait for a connection to free up is not quite the same as waiting for a single connection to be made. Perhaps we should default so some higher value here like 30 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/mperham/connection_pool#usage